Fix the nightly report summaries#1250
Closed
JanKrivanek wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Replaced by #1251 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the nightly “Skill Quality Report” summary table showing zero counts by updating how findings are counted from the skill-validator output.
Changes:
- Update error/warning/advisory counting logic to match emoji markers in validator output.
- Add an inline note describing the emoji markers used by skill-validator.
| const advisoryCount = (combined.match(/\bAdvisory\b/gi) || []).length; | ||
| const errorCount = (combined.match(/❌/g) || []).length; | ||
| const warningCount = (combined.match(/⚠/g) || []).length; | ||
| const advisoryCount = (combined.match(/ℹ️/g) || []).length; |
There was a problem hiding this comment.
The new finding counters rely on exact emoji codepoints. In particular, advisories are counted with /ℹ️/g (U+2139 + VS16), but the comment says the marker is ℹ and some outputs render without the variation selector, which would keep advisoryCount at 0. Consider matching both forms (e.g., allow optional VS16) and/or falling back to the previous word-based matching so the summary stays correct across skill-validator output formats.
Suggested change
| const advisoryCount = (combined.match(/ℹ️/g) || []).length; | |
| // Match ℹ (U+2139) with optional VS16 (U+FE0F) so both ℹ and ℹ️ are counted | |
| const advisoryCount = (combined.match(/\u2139\uFE0F?/g) || []).length; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The summary stats in nightly report were all zeroes